Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packet stream parser #2044

Merged
merged 11 commits into from Dec 27, 2019
Merged

Add packet stream parser #2044

merged 11 commits into from Dec 27, 2019

Conversation

brianc
Copy link
Owner

@brianc brianc commented Dec 27, 2019

This is mostly a work in progress look at some medium-term performance & maintainability improvements I want to make, by re-writing the parser, adding typescript, and starting to use this module "from the inside out" to find out where the perf bottlenecks are. I've identified a pretty significant (2x!!) performance improvement on some experimental code by removing some intermediate event emitters and streamlining the parsing code quite a bit. I'm not sure there's a way to land it in a non-disruptive way so I'm still investigating, but I want to land some of this work-in-progress stuff. It's in its own module right now so it shouldn't disturb the main library at all.

@brianc brianc merged commit 3278dce into master Dec 27, 2019
@brianc brianc deleted the bmc/packet-stream-parser branch December 27, 2019 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants